Code Style - apply PascalCase

[chriselion]

Proposed change(s)

Unity's C# style guide says

In the Unity namespace, public fields are PascalCase with no prefix
In the Unity namespace, public properties are PascalCase with no prefix

(as opposed to UnityEngine and UnityEditor namespaces, which have different conventions).

This PR updates all the public fields and properties that I could find (via API scraper) that were camelCase instead of PascalCase

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://ono.unity3d.com/unity-extra/unity-meta/files/@/ReferenceSource/CSharp/Assets/CSharpReference.cs

Types of change(s)

• Bug fix
• New feature
• Code refactor
• Breaking change
• Documentation update
• Other (please describe)

Checklist

• Added tests that prove my fix is effective or that my feature works
• Updated the changelog (if applicable)
• Updated the documentation (if applicable)
• Updated the migration guide (if applicable)

Other comments

[chriselion]

I renamed a few of these to be more consistent too.

[vincentpierre]

There should be some changes to the documentation I think.
https://github.com/Unity-Technologies/ml-agents/blame/api-PascalCase/docs/Learning-Environment-Examples.md#L364

Otherwise looks good

[chriselion]

😭 Yeah, I'll do a pass on those too.

[chriselion]

I skimmed through code blocks, and did a few spot checks with git grep foo -- docs/. and didn't find any others:

$ git grep maxStep -- docs/.
docs/Migrating.md:  instead of "camelCase"; for example, `Agent.maxStep` was renamed to
docs/Migrating.md:    `maxStep` information)
docs/Migrating.md:  - `maxStep` is now a public field on the Agent. (Was moved from

[mmattar]

❤️

[mmattar]

@chriselion - is there any error-ing/warning/pre-commit checks we can do to defend against this in the future?

[chriselion]

@mmattar Nothing that I'm aware of. It sounds like something the [Coding Support Tools package] (https://docs.unity3d.com/Packages/com.unity.coding@0.1/manual/index.html) could potentially handle but not sure if it does (and we don't currently have a way to enforce anything else it does like code formatting anyway).

More extreme, we could use that package to generate a dump of the API scraping and parse that.

[chriselion]

Followup for enforcing this automatically: https://jira.unity3d.com/browse/MLA-947

[JPhilipp]

Unity's C# style guide

@chriselion Is this document publicly available by any chance? I'd be interested to have a look (I understand it's also Microsoft C# convention to go for .PascalCase for public fields, whereas I'm always used to Unity fields being .camelCase; which means Unity developers need to choose either-or, resulting in mixes). Thanks!

[chriselion]

@JPhilipp I'll find out - AFAIK the only version is in Unity's internal repo, but there might be a public copy somewhere.

[chriselion]

@JPhilipp You can install the com.unity.coding package (it's in the public registry, but not visible by default), and once you do that, there's a copy of the file in
{your project}/Library/PackageCache/com.unity.coding@0.1.0-preview.13/Coding~/Conventions/CSharpReference.cs

Not exactly obvious :/ but hopefully that's enough to go on. Here's the line to add it to your list of dependencies:

ml-agents/DevProject/Packages/manifest.json

Line 7 in eedc3f9

"com.unity.coding": "0.1.0-preview.13",