Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLA-850] rename namespaces to Unity.MLAgents #3843

Merged
merged 5 commits into from
Apr 24, 2020
Merged

[MLA-850] rename namespaces to Unity.MLAgents #3843

merged 5 commits into from
Apr 24, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Apr 24, 2020 •
edited
Loading

Proposed change(s)

Change all namespaces from MLAgents* to Unity.MLAgents*. This brings us in line with package guidelines.

Steps taken were:

  • change the namespace in the proto defintions, and regenerate the proto files
  • search and replace "using MLAgents" to "using Unity.MLAgents"
  • search and replace "namespace MLAgents" to "namespace Unity.MLAgents"
  • update filter.yml
  • update markdown examples, changelog, migration guide.
  • fix StandaloneBuildTest test path for CI

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion changed the base branch from master to release_1_branch April 24, 2020 18:44
@chriselion chriselion merged commit 3f9865d into release_1_branch Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the release_1-MLA-850-namespace branch April 24, 2020 20:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd surfnerd approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @surfnerd