Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce numpy version #4274

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Reduce numpy version #4274

merged 1 commit into from
Jul 27, 2020

Conversation

andrewcoh
Copy link
Contributor

Proposed change(s)

This reduces max numpy version to <1.19.0 in ml-agents-envs to be compatible with TF 2.3.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Judging from tensorflow/tensorflow@79518fa older tf versions will also have problems with numpy 1.19.1 too

@andrewcoh andrewcoh merged commit c2add06 into master Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the reduce-numpy-ver branch July 27, 2020 20:43
@chriselion
Copy link
Contributor

@awjuliani Might want to consider this for a patch release too.

awjuliani pushed a commit that referenced this pull request Jul 30, 2020
@andrewcoh @awjuliani
Reduce numpy version in ml-agents-envs setup (#4274)
2f72c2f
awjuliani pushed a commit that referenced this pull request Jul 30, 2020
@andrewcoh @awjuliani
Reduce numpy version in ml-agents-envs setup (#4274)
d495cc3
@MillionBones
Copy link

Since r_5 had made this change, now
pip3 install mlagents
would cause the incompatible error
maybe should also update the package in PyPI

@chriselion
Copy link
Contributor

@MillionBones The changes for release_5 were published to pypi as version 0.18.1:
https://pypi.org/project/mlagents/0.18.1/
https://pypi.org/project/mlagents-envs/0.18.1/

@chriselion chriselion mentioned this pull request Aug 6, 2020
Merged
2 tasks
chriselion pushed a commit that referenced this pull request Aug 6, 2020
Update CHANGELOG.md for #4274 (#4308)
533e66e 
* Update CHANGELOG.md
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
surfnerd pushed a commit that referenced this pull request Aug 6, 2020
@surfnerd
Update CHANGELOG.md for #4274 (#4308)
6dc0618 
* Update CHANGELOG.md
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
surfnerd added a commit that referenced this pull request Aug 6, 2020
@surfnerd
Update CHANGELOG.md for #4274 (#4308) (#4314)
aab2cfd 
* Update CHANGELOG.md
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>

Co-authored-by: Chris Elion <chris.elion@unity3d.com>
@chriselion chriselion mentioned this pull request Dec 4, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewcoh @chriselion @MillionBones