Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation using IHeuristicProvider. #4849

Merged
merged 27 commits into from
Jan 20, 2021
Merged

Initial implementation using IHeuristicProvider. #4849

merged 27 commits into from
Jan 20, 2021

Conversation

surfnerd
Copy link
Contributor

@surfnerd surfnerd commented Jan 12, 2021 •
edited
Loading

Proposed change(s)

An initial implementation using IHeuristicProvider which allows both IActuators and Agent to implement the Heuristic function in order to generate actions for behaviors. Agents will have their heuristic method called if their BrainParameters are set up that way. Otherwise, any IActuator that implements IHeuristic will have its Heuristic method called on it with the appropriate ActionBuffers for that IActuator.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@surfnerd surfnerd self-assigned this Jan 12, 2021
@surfnerd surfnerd marked this pull request as ready for review January 13, 2021 22:52
@surfnerd surfnerd changed the title Initial implementation using IHeuristic. Initial implementation using IHeuristicProvider. Jan 13, 2021
chriselion
chriselion approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but looks good. Just want to make sure that if we're not going to rename the Match3 classes that the related changes get reverted too.

@surfnerd surfnerd merged commit af6096e into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-heuristic-interface branch January 20, 2021 00:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@dongruoping dongruoping Awaiting requested review from dongruoping

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees

@surfnerd surfnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surfnerd @chriselion