remove unnecessary allocs in SideChannelMananger #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Jan 27, 2021
| { | ||
| // Early out so that we don't create the MemoryStream or BinaryWriter. | ||
| // This is the most common case. | ||
| return Array.Empty<byte>(); |
There was a problem hiding this comment.
I didn't try this with null instead of Empty(), but I'm 99% sure the protobuf code will choke on null.
chriselion
commented
Jan 27, 2021
| @@ -30,6 +30,9 @@ removed when training with a player. The Editor still requires it to be clamped | |||
| #### com.unity.ml-agents (C#) | |||
| - Fix a compile warning about using an obsolete enum in `GrpcExtensions.cs`. (#4812) | |||
| - CameraSensor now logs an error if the GraphicsDevice is null. (#4880) | |||
| - Removed unnecessary memory allocations in `ActuatorManager.UpdateActionArray()` (#4877) | |||
There was a problem hiding this comment.
@surfnerd I added our other PRs here. If this gets repetitive, we can group these into a nested list later.
surfnerd
approved these changes
Jan 27, 2021
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
How it started
How it's going
This early-outs from GetSideChannelMessage if there are no messages to process. This should be the case the vast majority of the time, especially during inference (unless the user is actively doing something like calling
StatsRecorder.Add()).Thanks @szantner for reporting!
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#4883
Types of change(s)
Checklist
Other comments