Add CreateActuators API, obsolete old method. #4899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the original method. The original method will be removed in the future.
surfnerd
commented
Feb 1, 2021
| @@ -12,8 +13,21 @@ public abstract class ActuatorComponent : MonoBehaviour | |||
| /// Create the IActuator. This is called by the Agent when it is initialized. | |||
| /// </summary> | |||
| /// <returns>Created IActuator object.</returns> | |||
| [Obsolete("Use CreateActuators instead.")] | |||
There was a problem hiding this comment.
since this is abstract people will still need to override it until we remove it. The migration doc tells them how to disable the warnings.
There was a problem hiding this comment.
Ugh, this is annoying but I'm not sure if not marking it obsolete is worse.
There was a problem hiding this comment.
yeah, i went through the same thought process and ended up here.
chriselion
approved these changes
Feb 1, 2021
delete-merged-branch
bot
deleted the
develop-return-multiple-actuators
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add CreateActuators API to ActuatorComponent, obsolete CreateActuator, and have the base implementation wrap a call to the original in an Array and return it.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments