Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more generic exception catching #4921

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Use more generic exception catching #4921

merged 2 commits into from
Feb 8, 2021

Conversation

awjuliani
Copy link
Contributor

Proposed change(s)

Fixes an issue where a permission error was not properly caught when writing the Timer file, causing the environment to crash.

#4911

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add a changelog entry for it too?

@awjuliani awjuliani merged commit 0fbb195 into master Feb 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-permission-timers branch February 8, 2021 21:41
@awjuliani awjuliani mentioned this pull request Feb 8, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awjuliani @chriselion