[MLA-1762] reduce memory allocations from DiscreteActionOutputApplier #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Feb 8, 2021
| public int Sample(float[] cmf) | ||
| /// <param name="branchSize">The number of possible branches, i.e. the effective size of the cmf array.</param> | ||
| /// <returns>A sampled index from the CMF ranging from 0 to branchSize-1.</returns> | ||
| public int Sample(float[] cmf, int branchSize) |
There was a problem hiding this comment.
Because the float[] might be larger than we need now, we also pass the effective size of the array.
We could instead (or in additionally) repeat the final sumProb value in ComputeCdf()
vincentpierre
approved these changes
Feb 8, 2021
| readonly ActionSpec m_ActionSpec; | ||
| readonly int[] m_StartActionIndices; | ||
| readonly float[] m_cdfBuffer; |
|
|
||
| if (src.data.batch != dst.data.batch) | ||
| { | ||
| throw new ArgumentException("Batch size for input and output data is different!"); |
There was a problem hiding this comment.
Are these exceptions no longer needed ?
There was a problem hiding this comment.
Not sure they were ever necessary in the first place. The temporary tensors they were referencing are no longer needed.
surfnerd
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
There were several intermediate tensors and float arrays (1d and 2d) allocated on each call. This reuses a single float[] for the CDF, and eliminates the other intermediate allocations. Now for each action, we compute the CDF and sample the result directly to the output ActionBuffers.DiscreteActions.
Before:
After:
Types of change(s)
Checklist
Other comments