surface specific GRPC errors more visibly #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Feb 9, 2021
| switch (rpcException.Status.StatusCode) | ||
| { | ||
| case StatusCode.Unavailable: | ||
| // This can happen when python disconnects. Ignore it to avoid noisy logs. |
There was a problem hiding this comment.
This happens roughly 20%-25% of the time when hitting Ctrl-C from python. Not exactly sure why it happens instead of the non-200 status (handled above).
chriselion
commented
Feb 9, 2021
| break; | ||
| default: | ||
| // Other unknown errors. Keep these quiet for now. | ||
| break; |
There was a problem hiding this comment.
I could be convinced to log other exceptions here (maybe as Info instead of Error). That would at least help us for future unknown unknowns.
chriselion
commented
Feb 9, 2021
| catch | ||
| { | ||
| // Fall-through for other error types |
There was a problem hiding this comment.
Same comment about logging here - I don't think we ever hit it, so it would be nice to know when we do, but it's also potentially noisy to users.
added 2 commits
February 9, 2021 17:18
delete-merged-branch
bot
deleted the
MLA-1719-better-communicator-errors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
We want to ignore some GRPC errors but raise others. Currently just opting in to one error (ResourceExhausted, when the payload is too large), but I'm willing to reconsider.
Also not sure how to test this; I did it manually with some breakpoints (to confirm the
StatusCode.Unavailablecase) and modifying GridWorld with a large uncompressed sensor (to confirmStatusCode.ResourceExhausted),Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1719
Types of change(s)
Checklist