Upgrade PyTorch version for python 3.9 #5028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
March 3, 2021 16:10
dongruoping
changed the title
chriselion
reviewed
Mar 10, 2021
| # Windows ver. of PyTorch doesn't work from PyPi. Installation: | ||
| # https://github.com/Unity-Technologies/ml-agents/blob/main/docs/Installation.md#windows-installing-pytorch | ||
| 'torch>=1.6.0,<1.8.0;platform_system!="Windows"', | ||
| "torch>=1.8.0,<1.9.0;(platform_system!='Windows' and python_version>='3.9')", |
There was a problem hiding this comment.
Maybe add a comment about torch only working on py3.9 for 1.8.0 and above (and link to the issue)
chriselion
approved these changes
Mar 10, 2021
added 3 commits
March 10, 2021 17:12
|
last commit only contains change for comment. skipping the test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
A bug in PyTorch with python 3.9 (see thread) cause a segmentation fault at python finalization on Linux. The issue is fixed in pytorch 1.8.
Upgrade pytorch dependency to 1.8 for python 3.9 and run pytests with different versions of python and pytorch.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments