-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLA-1809] catch mismatched observation sizes #5030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Mar 4, 2021
vincentpierre
approved these changes
Mar 4, 2021
3 tasks
vincentpierre
approved these changes
Mar 5, 2021
@@ -258,17 +285,25 @@ def _raise_on_nan_and_inf(data: np.array, source: str) -> np.array: | |||
|
|||
@timed | |||
def _process_rank_one_or_two_observation( | |||
obs_index: int, shape: Tuple[int, ...], agent_info_list: Collection[AgentInfoProto] | |||
obs_index: int, | |||
observation_spec: ObservationSpec, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is better now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Even though we check and assert on the Unity side, it's possible to get observations of different size send over. This will cause a numpy exception when trying to pack them into an array:
This change adds an extra check that the observations all have the shape of the observation spec:
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://forum.unity.com/threads/walker-demo-adding-blockcontact-observation-valueerror-setting-an-array-element-with-a-sequence.1065587/#post-6895055
Types of change(s)
Checklist