[MLA-1731] update pip instructions #5074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ervteng
reviewed
Mar 10, 2021
utils/validate_release_links.py
Outdated
| or PIP_INSTALL_PATTERN.search(line) is None | ||
| or pip_allow_pattern.search(line) is not None | ||
| ) | ||
| # if not pip_install_ok: |
There was a problem hiding this comment.
should this comment be here?
There was a problem hiding this comment.
Oops, that was debugging, will remove.
ervteng
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Update all
pip installinstructions for mlagents and mlagents_envs to specify the released pypi version. This standardizes on the command to be "python -m pip" instead of "pip" or "pip3", which is the recommended approach (see link).This will run at the same time that we update the
release_xyz_docslinks.Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://www.youtube.com/watch?list=PLWBKAf81pmOaP9naRiNAqug6EBnkPakvY&v=gnYdk_U6UQ0&feature=youtu.be