Skip to content

Conversation

Musubee
Copy link
Contributor

@Musubee Musubee commented Mar 10, 2021

Proposed change(s)

Describe the changes made in this PR.

There was an incomplete sentence in the installation docs, so I added a short ending.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Screenshot taken from my branch:
updated_documentation

This is my first open-source contribution, so let me know if there's anything I should've done differently!

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2021

CLA assistant check)
All committers have signed the CLA.

@Musubee Musubee marked this pull request as draft March 10, 2021 23:48
@Musubee Musubee marked this pull request as ready for review March 10, 2021 23:48
@Musubee
Copy link
Contributor Author

Musubee commented Mar 10, 2021

Having issues adding you as a reviewer/assignee @surfnerd

Any ideas on why?

@chriselion
Copy link
Contributor

Looks like this got lost in a merge the other day, thanks for catching it.

@chriselion chriselion merged commit eced65c into Unity-Technologies:main Mar 11, 2021
@surfnerd
Copy link
Contributor

@Musubee , nope. At least it looks like @chriselion got it.

@Musubee Musubee deleted the doc-fix branch March 11, 2021 00:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants