Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghost curriculum #5098

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Fix ghost curriculum #5098

merged 4 commits into from
Mar 12, 2021

Conversation

andrewcoh
Copy link
Contributor

Proposed change(s)

Curriculum with self-play would not update because the ghost trainer steps are not 1:1 with the wrapped trainer steps.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@andrewcoh andrewcoh changed the title Fix ghost curr Fix ghost curriculum Mar 12, 2021
@andrewcoh andrewcoh merged commit f200b90 into main Mar 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-ghost-curr branch March 12, 2021 16:54
ervteng pushed a commit that referenced this pull request Mar 12, 2021
* use get step to determine curriculum

* add to CHANGELOG

* Make step in trainer private (#5099)

Co-authored-by: Ervin T <ervin@unity3d.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants