Skip to content

Fix end episode for POCA, add warning for group reward if not POCA #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix end episode for POCA, add warning for group reward if not POCA #5113

merged 2 commits into from
Mar 15, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Mar 15, 2021

Proposed change(s)

Fixed a bug where if end_episode is called, POCA would not clear group rewards. Added test for this.

Also, added a warning if group rewards are received by PPO or SAC.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested review from andrewcoh and chriselion March 15, 2021 17:21
@ervteng ervteng merged commit f7d6dc3 into main Mar 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-group-reward-ppo branch March 15, 2021 23:24
ervteng pushed a commit that referenced this pull request Mar 15, 2021
Fix end episode for POCA, add warning for group reward if not POCA (#…
4f0befd 
…5113)

* Fix end episode for POCA, add warning for group reward if not POCA

* Add missing imports
@ervteng ervteng mentioned this pull request Mar 15, 2021
Merged
10 tasks
ervteng pushed a commit that referenced this pull request Mar 16, 2021
[cherry-pick] Fix group rewards for POCA, add warning for non-POCA tr…
7cbb832 
…ainers (#5120)

* Fix end episode for POCA, add warning for group reward if not POCA (#5113)

* Fix end episode for POCA, add warning for group reward if not POCA

* Add missing imports

* Use np.any, which is faster
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chriselion chriselion Awaiting requested review from chriselion

1 more reviewer

@andrewcoh andrewcoh andrewcoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ervteng @andrewcoh