Pragma warnings into the void. #5117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ervteng
approved these changes
Mar 15, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 15, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 15, 2021
|
I thought we had warnings as errors in the project - should this have failed CI? |
|
It’s only used for 2018.4 where apparently that check isn’t a warning.
On Mon, Mar 15, 2021 at 16:44 Chris Elion ***@***.***> wrote:
I thought we had warnings as errors in the project - should this have
failed CI?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#5117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKLGSG4JA2OEPMJKPBEC5TTD2LUNANCNFSM4ZHNDZ6A>
.
--
*Chris Goy*
Senior Software Developer | ML Agents
San Francisco
<https://unity3d.com/?utm_source=unity3d&utm_medium=email&utm_campaign=company-information-2016-Global-Unity-Email-Sig>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Pragma warnings into the void.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)