Skip to content

Adding the goal conditioning sensors with the new observation specs #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 29, 2021
Merged

Adding the goal conditioning sensors with the new observation specs #5159

merged 12 commits into from
Mar 29, 2021

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Adding the goal conditioning sensors with the new observation specs

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from awjuliani March 19, 2021 03:00
@vincentpierre vincentpierre self-assigned this Mar 19, 2021
@vincentpierre vincentpierre force-pushed the goal-conditioning-sensors-3 branch from fe49ee0 to 570df7f Compare March 19, 2021 03:04
chriselion
chriselion reviewed Mar 19, 2021
View reviewed changes
chriselion
chriselion reviewed Mar 19, 2021
View reviewed changes
chriselion
chriselion reviewed Mar 19, 2021
View reviewed changes
chriselion
chriselion reviewed Mar 19, 2021
View reviewed changes
chriselion
chriselion approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending the feedback.

chriselion
chriselion reviewed Mar 29, 2021
View reviewed changes
@vincentpierre vincentpierre merged commit ca0fca7 into main Mar 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the goal-conditioning-sensors-3 branch March 29, 2021 18:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awjuliani awjuliani Awaiting requested review from awjuliani

1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @chriselion