Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default barracuda behavior #5175

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

chriselion
Copy link
Contributor

Proposed change(s)

#4925 added InferenceDevice.Burst, but we couldn't change the behavior of assets that use InferenceDevice.CPU in a minor release.

This renames the 0 value of InferenceDevice, which will behave the same as InferenceDevice.Burst. It's still possible to force the old behavior as a fallback (and if you're setting InferenceDevice.CPU in code, this doesn't change anything).

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Code refactor
  • Breaking change

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested a review from surfnerd March 22, 2021 22:41
Copy link
Contributor

@surfnerd surfnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😐

@chriselion chriselion merged commit c68ffb1 into main Mar 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the MLA-1765-update-default-barracuda-type branch March 23, 2021 01:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants