Skip to content

Making VectorActionSize and VectorActionSpaceType internal #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Making VectorActionSize and VectorActionSpaceType internal #5214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions com.unity.ml-agents/Runtime/Policies/BrainParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Unity.MLAgents.Policies
/// This is deprecated. Agents can now use both continuous and discrete actions together.
/// </summary>
[Obsolete("Continuous and discrete actions on the same Agent are now supported; see ActionSpec.")]
public enum SpaceType
internal enum SpaceType
{
/// <summary>
/// Discrete action space: a fixed number of options are available.
Expand Down Expand Up @@ -81,7 +81,7 @@ public ActionSpec ActionSpec
/// </value>
[Obsolete("VectorActionSize has been deprecated, please use ActionSpec instead.")]
[FormerlySerializedAs("vectorActionSize")]
public int[] VectorActionSize = new[] { 1 };
internal int[] VectorActionSize = new[] { 1 };

/// <summary>
/// The list of strings describing what the actions correspond to.
Expand All @@ -94,7 +94,7 @@ public ActionSpec ActionSpec
/// </summary>
[Obsolete("VectorActionSpaceType has been deprecated, please use ActionSpec instead.")]
[FormerlySerializedAs("vectorActionSpaceType")]
public SpaceType VectorActionSpaceType = SpaceType.Discrete;
internal SpaceType VectorActionSpaceType = SpaceType.Discrete;

[SerializeField]
[HideInInspector]
Expand All @@ -121,7 +121,7 @@ public BrainParameters Clone()
}

/// <summary>
/// Propogate ActionSpec fields from deprecated fields
/// Propagate ActionSpec fields from deprecated fields
/// </summary>
private void UpdateToActionSpec()
{
Expand Down