Move GridSensor into main package #5256
Conversation
| @@ -75,7 +75,7 @@ public IEnumerator RuntimeApiTestWithEnumeratorPasses() | |||
|
|
|||
| // Can't actually create an Agent with InferenceOnly and no model, so change back | |||
| behaviorParams.BehaviorType = BehaviorType.Default; | |||
| #if MLA_UNITY_PHSYICS_MODULE | |||
| #if MLA_UNITY_PHYSICS_MODULE | |||
There was a problem hiding this comment.
barely noticed the difference... not sure why this wasn't causing any trouble
There was a problem hiding this comment.
Accidentally found a bug in test - this was never run and in fact the test will fail if this part was enabled.
| @@ -1,230 +0,0 @@ | |||
| # Summary | |||
There was a problem hiding this comment.
Deleted the doc since most of the information here doesn't apply anymore.
Only CountingGridSensor is in extension now and I don't think that worth a whole doc.
| } | ||
|
|
||
| // Copied from GridSensorTests in main package | ||
| public static float[][] DuplicateArray(float[] array, int numCopies) |
There was a problem hiding this comment.
Didn't find a good way to share utility methods between main package tests and extension tests
There was a problem hiding this comment.
you can have the extension package depend on an asmdef that has this method in it. Then you can use it between both.
| @@ -319,7 +319,7 @@ public int Write(ObservationWriter writer) | |||
| // For each ray, write the information to the observation buffer | |||
| for (var rayIndex = 0; rayIndex < numRays; rayIndex++) | |||
| { | |||
| m_RayPerceptionOutput.RayOutputs[rayIndex].ToFloatArray(numDetectableTags, rayIndex, m_Observations); | |||
| m_RayPerceptionOutput.RayOutputs?[rayIndex].ToFloatArray(numDetectableTags, rayIndex, m_Observations); | |||
There was a problem hiding this comment.
fix RuntimeAPITest
Co-authored-by: Chris Goy <christopherg@unity3d.com>
| will be slightly different. | ||
|
|
||
| For creating your GridSensor implementation with custom data: | ||
| * To create custom GridSensor, derive from `GridSensorBase` instead of `GridSensor`. Besides overriding |
There was a problem hiding this comment.
This should go in the documentation somewhere (and refer to it from the migration guide)
Co-authored-by: Chris Elion <chris.elion@unity3d.com>
Proposed change(s)
Move OneHotGridSensor and dependent files into main package. CountingGridSensor is still in extension with the concern of compression type limits.
By default GridSensorComponent creates a OneHotGridSensor.
Also added check if physics module exists since it's only optional dependency in package.
The rest of the changes are trivial: variable names, moving files, namespaces.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments