Rider suggested cleanup, part 1 #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Apr 15, 2021
| @@ -8,7 +6,7 @@ public class NumberTile : MonoBehaviour | |||
| public Material DefaultMaterial; | |||
| public Material SuccessMaterial; | |||
|
|
|||
| private bool m_Visited = false; | |||
There was a problem hiding this comment.
Not sure how people feel about. My instinct is to a) be explicit (from python) and b) always initialize everything (coming from C++), but Rider likes to complain about it.
There was a problem hiding this comment.
Yeah I think making them explicit is not a bad thing and sometimes it feels safer (I know it works that way but I like seeing it written that way).
No strong opinions anyway.
chriselion
commented
Apr 15, 2021
| @@ -1,8 +1,9 @@ | |||
| using System; | |||
| using System.Linq; | |||
There was a problem hiding this comment.
This is only needed in non-editor compilation.
dongruoping
approved these changes
Apr 15, 2021
| @@ -8,7 +6,7 @@ public class NumberTile : MonoBehaviour | |||
| public Material DefaultMaterial; | |||
| public Material SuccessMaterial; | |||
|
|
|||
| private bool m_Visited = false; | |||
There was a problem hiding this comment.
Yeah I think making them explicit is not a bad thing and sometimes it feels safer (I know it works that way but I like seeing it written that way).
No strong opinions anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Low-hanging fruit, mostly unused
using ...Types of change(s)