Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] Fix null ref exception in the demo recorder #5274

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Apr 15, 2021

Proposed change(s)

A null reference exception was being thrown when Num Steps to Record was > 0 AND the Record checkbox was unticked.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from vincentpierre April 15, 2021 21:36
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for clarity, I would do :

 if( !Record){ 
     return;
  } 

 *rest of the code*

@ervteng
Copy link
Contributor Author

ervteng commented Apr 15, 2021

Looks good, but for clarity, I would do :

 if( !Record){ 
     return;
  } 

 *rest of the code*

Done

@ervteng ervteng merged commit 18706a6 into main Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-fix-null-demorecorder branch April 15, 2021 23:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants