check for missing AbstractBoard, display warning #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongruoping
approved these changes
Apr 16, 2021
| var gameObj = new GameObject("board"); | ||
| var actuatorComponent = gameObj.AddComponent<Match3ActuatorComponent>(); | ||
| var actuators = actuatorComponent.CreateActuators(); | ||
| Assert.AreEqual(0, actuators.Length); |
There was a problem hiding this comment.
might be good to also check it doesn't throw exceptions
There was a problem hiding this comment.
If it did throw exceptions, the test would fail.
chriselion
pushed a commit
that referenced
this pull request
Apr 16, 2021
vincentpierre
pushed a commit
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
If the AbstractBoard is missing, sensor creation will fail. I think it makes sense to just return empty arrays for the sensors and actuators in this case.
Also added a warning to the respective editor components.
I tried, but we can't add
[RequireComponent(typeof(AbstractBoard))], since AbstractBoard is, well, abstract.Types of change(s)
Checklist