Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying the changelog for release 17 #5277

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Modifying the changelog for release 17 #5277

merged 3 commits into from
Apr 16, 2021

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Modifying the changelog for the release

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Apr 16, 2021
chriselion
chriselion reviewed Apr 16, 2021
View reviewed changes
com.unity.ml-agents/CHANGELOG.md Outdated
### Bug Fixes


## [2.0.0-preview] - 2021-04-22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be 2.0.0-exp.1 (since that's what's here):

ml-agents/com.unity.ml-agents/package.json

Line 4 in f94a75a

"version": "2.0.0-exp.1",

chriselion
chriselion approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this passes package validation, then go for it, but might be worth running locally to test.

@vincentpierre vincentpierre merged commit da50376 into main Apr 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-release_17_changelog branch April 16, 2021 01:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @chriselion