Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back root reference in grid sensor #5300

Merged
merged 8 commits into from
Apr 23, 2021
Merged

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

Describe the changes made in this PR.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping dongruoping requested a review from chriselion April 21, 2021 22:16
@chriselion
Copy link
Contributor

Do you think "RootReference" is still a good user-facing name for this? Maybe something like "AgentGameObject" or "GameObjectToIgnore" of "FilteredGameObject"?

@dongruoping
Copy link
Contributor Author

Do you think "RootReference" is still a good user-facing name for this? Maybe something like "AgentGameObject" or "GameObjectToIgnore" of "FilteredGameObject"?

agreed, renamed it to AgentGameObject

@dongruoping dongruoping merged commit 8859535 into main Apr 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-grid-rootrefernece branch April 23, 2021 20:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants