Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛🔨] Re-adding the validation of the minimal cnn input size #5345

Merged
merged 1 commit into from
May 7, 2021
Merged

[🐛🔨] Re-adding the validation of the minimal cnn input size #5345

merged 1 commit into from
May 7, 2021

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Fix for #5342 Readding a proper UnityTrainersException. Instead of raising a Runtime or ZeroDivisionError error.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from chriselion May 7, 2021 16:43
@vincentpierre vincentpierre self-assigned this May 7, 2021
@vincentpierre vincentpierre changed the title Reading the validation of the minimal cnn input size [🐛🔨] Reading the validation of the minimal cnn input size May 7, 2021
@vincentpierre vincentpierre merged commit f063416 into main May 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-invalid-cnn-input branch May 7, 2021 20:48
vincentpierre added a commit that referenced this pull request May 7, 2021
@vincentpierre
Readding the validation of the minimal cnn input size (#5345)
ef7394b
@vincentpierre vincentpierre mentioned this pull request May 7, 2021
Merged
10 tasks
@surfnerd surfnerd mentioned this pull request May 10, 2021
Closed
vincentpierre added a commit that referenced this pull request May 10, 2021
@vincentpierre
Readding the validation of the minimal cnn input size (#5345) (#5346)
9f88169
@chriselion chriselion changed the title [🐛🔨] Reading the validation of the minimal cnn input size [🐛🔨] Re-adding the validation of the minimal cnn input size May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd surfnerd approved these changes

@chriselion chriselion Awaiting requested review from chriselion

Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @surfnerd