Adding a fully connected visual encoder for super small visual input + tests #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
commented
May 10, 2021
| kernel_init=Initialization.KaimingHeNormal, | ||
| kernel_gain=1.41, # Use ReLU gain | ||
| ), | ||
| nn.LeakyReLU(), |
There was a problem hiding this comment.
We could use another activation here, but I think ReLU is enough.
vincentpierre
changed the title
chriselion
reviewed
May 10, 2021
chriselion
reviewed
May 10, 2021
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "vis_class_and_size", |
There was a problem hiding this comment.
nit: you should be able to do "vis_class, size" here, and test_visual_encoder_trains(vis_class, size) as the test definition. Not a big deal though.
There was a problem hiding this comment.
I did not know I could do that. Thanks!
chriselion
approved these changes
May 10, 2021
delete-merged-branch
bot
deleted the
develop-fully-connected-visual-encoder
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Adding a fully connected option to visual encoding.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments