[bug-fix] Make resnet barracuda-compatible #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2021 12:20
surfnerd
approved these changes
May 12, 2021
surfnerd
pushed a commit
that referenced
this pull request
May 13, 2021
surfnerd
added a commit
that referenced
this pull request
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
In the ResNet encoder, we were grabbing the batch size from the actual observations themselves and using that to reshape the final output of the conv layer. This was not compatible with current versions of the Barracuda importer. Now we just cache it first and use that value.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://forum.unity.com/threads/sac-training-very-unstable.1104580/#post-7131539
Types of change(s)
Checklist
Other comments