-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Initialize-from custom checkpoints #5525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2d63280
3c38be2
736846a
f0ba260
2b9ffb3
4361ae7
1b39d89
ef9869c
9fbb7ed
b0c2361
fcecd76
fa38aa8
8c19be4
0c54731
0caf020
308b640
e693210
3981e10
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,6 @@ def generate(self, behavior_name: str) -> Trainer: | |
self.ghost_controller, | ||
self.seed, | ||
self.param_manager, | ||
self.init_path, | ||
self.multi_gpu, | ||
) | ||
|
||
|
@@ -80,7 +79,6 @@ def _initialize_trainer( | |
ghost_controller: GhostController, | ||
seed: int, | ||
param_manager: EnvironmentParameterManager, | ||
init_path: str = None, | ||
multi_gpu: bool = False, | ||
) -> Trainer: | ||
""" | ||
|
@@ -96,12 +94,9 @@ def _initialize_trainer( | |
:param ghost_controller: The object that coordinates ghost trainers | ||
:param seed: The random seed to use | ||
:param param_manager: EnvironmentParameterManager, used to determine a reward buffer length for PPOTrainer | ||
:param init_path: Path from which to load model, if different from model_path. | ||
:return: | ||
""" | ||
trainer_artifact_path = os.path.join(output_path, brain_name) | ||
if init_path is not None: | ||
trainer_settings.init_path = os.path.join(init_path, brain_name) | ||
Comment on lines
-103
to
-104
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why init_path is passed up to here, was there a specific reason to set this in trainer factory? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you tried using init_path and see if it does what we expect out of it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct. Previously |
||
|
||
min_lesson_length = param_manager.get_minimum_reward_buffer_size(brain_name) | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.