Update dotnet-format to address breaking changes introduced by upstream changes #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongruoping
approved these changes
Sep 2, 2021
maryamhonari
approved these changes
Sep 2, 2021
sini
added a commit
that referenced
this pull request
Sep 2, 2021
…am changes (#5528) Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option. The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
11 tasks
dongruoping
pushed a commit
that referenced
this pull request
Sep 2, 2021
maryamhonari
pushed a commit
that referenced
this pull request
Sep 24, 2021
…am changes (#5528) Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option. The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
sini
added a commit
that referenced
this pull request
Sep 29, 2021
…am changes (#5528) Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option. The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
maryamhonari
pushed a commit
that referenced
this pull request
Oct 6, 2021
…am changes (#5528) Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option. The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
maryamhonari
added a commit
that referenced
this pull request
Oct 6, 2021
…ed by upstream changes (#5528)"
10 tasks
maryamhonari
added a commit
that referenced
this pull request
Oct 18, 2021
* init petting_zoo registry * cherrypick Custom trainer editor analytics (#5511) * cherrypick "Update dotnet-format to address breaking changes introduced by upstream changes (#5528)" * Update colab to match pettingZoo import api * ToRevert: pull exp-petting-registry branch * Add init file to tests * Install pettingzoo-unity requirements for pytest * update pytest command * Add docstrings and comments * update coverage to pettingzoo folder * unset log level * update env string
miguelalonsojr
pushed a commit
that referenced
this pull request
Jan 27, 2022
* init petting_zoo registry * cherrypick Custom trainer editor analytics (#5511) * cherrypick "Update dotnet-format to address breaking changes introduced by upstream changes (#5528)" * Update colab to match pettingZoo import api * ToRevert: pull exp-petting-registry branch * Add init file to tests * Install pettingzoo-unity requirements for pytest * update pytest command * Add docstrings and comments * update coverage to pettingzoo folder * unset log level * update env string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using
dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option.The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Internal tracking issue: https://jira.unity3d.com/browse/MLA-2198
Other projects experience similar issues: icosa-foundation/open-brush#167
dotnet-format issues tracking this:
dotnet/format#1317
dotnet/format#1318
Types of change(s)
Checklist
Other comments