Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures on trunk with input system 1.1.1 #5542

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Fix test failures on trunk with input system 1.1.1 #5542

merged 3 commits into from
Sep 20, 2021

Conversation

dongruoping
Copy link
Contributor

@dongruoping dongruoping commented Sep 20, 2021 •
edited
Loading

Proposed change(s)

Some game objects left over from input system tests is causing other tests to fail during tear down with input system package going from 1.1.0 to 1.1.1.

Clean up all the game objects in input system tests.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

JIRA

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping
Copy link
Contributor Author

Confirmed the tests passed (see commit 5eebf5a)

maryamhonari
maryamhonari approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@maryamhonari maryamhonari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongruoping dongruoping changed the title Fix input system test errors Fix test failures on trunk with input system 1.1.1 Sep 20, 2021
@dongruoping dongruoping merged commit ee02841 into main Sep 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-fix-input-test branch September 20, 2021 22:47
maryamhonari pushed a commit that referenced this pull request Sep 24, 2021
@dongruoping @maryamhonari
Fix test failures on trunk with input system 1.1.1 (#5542)
f9ba5c1
maryamhonari pushed a commit that referenced this pull request Nov 5, 2021
@dongruoping @maryamhonari
Fix test failures on trunk with input system 1.1.1 (#5542)
e8420d3
@maryamhonari maryamhonari mentioned this pull request Nov 5, 2021
Merged
10 tasks
maryamhonari added a commit that referenced this pull request Nov 5, 2021
@maryamhonari @dongruoping
[Cherrypick] Fix test failures on trunk with input system 1.1.1 (#5542)…
04653e8 
… to 2.0.1 verified (#5608)

* Fix test failures on trunk with input system 1.1.1 (#5542)

* Update changeLog

Co-authored-by: Ruo-Ping Dong <ruoping.dong@unity3d.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryamhonari maryamhonari maryamhonari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongruoping @maryamhonari