Restart crashed Unity environments #5553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Update the SubprocessEnvManager to restart workers when the underlying Unity environments crash.
When a worker receives an ENV_EXITED signal it will now:
This behavior can be limited via a rate limit, max lifetime limit, or both. The configuration options for both are shown below with their default values.
They can of course be passed via CLI arguments as well
Disabling this feature
--restarts-rate-limit-n=-1
--max-lifetime-restarts=-1
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Internal JIRA: https://jira.unity3d.com/browse/MLA-1344
Types of change(s)
Checklist