-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart crashed Unity environments #5553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max_lifetime_restarts restarts_rate_limit_n restarts_rate_limit_period_s
hvpeteet
changed the title
[WIP] Restart crashed Unity environments
Restart crashed Unity environments
Sep 28, 2021
hvpeteet
requested review from
miguelalonsojr and
maryamhonari
and removed request for
vincentpierre
September 29, 2021 20:35
miguelalonsojr
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fat green light!!!!
maryamhonari
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Update the SubprocessEnvManager to restart workers when the underlying Unity environments crash.
When a worker receives an ENV_EXITED signal it will now:
This behavior can be limited via a rate limit, max lifetime limit, or both. The configuration options for both are shown below with their default values.
They can of course be passed via CLI arguments as well
Disabling this feature
--restarts-rate-limit-n=-1
--max-lifetime-restarts=-1
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Internal JIRA: https://jira.unity3d.com/browse/MLA-1344
Types of change(s)
Checklist