Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop add training area replicator #5568

Merged
merged 15 commits into from
Oct 13, 2021

Conversation

miguelalonsojr
Copy link
Collaborator

Proposed change(s)

Added a new feature for replicating training areas during runtime.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-2237

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@miguelalonsojr miguelalonsojr force-pushed the develop-add-training-area-replicator branch from 7636fa4 to e1777e8 Compare October 5, 2021 18:35
…ty-Technologies/ml-agents into develop-add-training-area-replicator

Merging changes from github.com.
Copy link
Contributor

@hvpeteet hvpeteet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Miguel, the PR looks good I just had a few comments.

Was there a plan to update an example env + yaml in another PR? I remember rumblings about that but I didn't recall the decision.

com.unity.ml-agents/CHANGELOG.md Outdated Show resolved Hide resolved
com.unity.ml-agents/Runtime/Communicator/ICommunicator.cs Outdated Show resolved Hide resolved
docs/Learning-Environment-Create-New.md Outdated Show resolved Hide resolved
ml-agents-envs/mlagents_envs/environment.py Outdated Show resolved Hide resolved
miguelalonsojr and others added 5 commits October 6, 2021 15:50
Co-authored-by: Henry Peteet <henry.peteet@unity3d.com>
Co-authored-by: Henry Peteet <henry.peteet@unity3d.com>
Co-authored-by: Henry Peteet <henry.peteet@unity3d.com>
…ty-Technologies/ml-agents into develop-add-training-area-replicator

Merging CR suggestions.
Copy link
Contributor

@hvpeteet hvpeteet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miguelalonsojr miguelalonsojr merged commit 003e8ae into main Oct 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-add-training-area-replicator branch October 13, 2021 13:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants