Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small bugfixes to pettingzoo wrapper #5589

Merged

Conversation

hvpeteet
Copy link
Contributor

Proposed change(s)

A couple of bugfixes I needed when testing with MLA --> PettingZoo --> RLlib

  1. Add the missing _cumulative_rewards property
  2. Update agent_selection to not error out when an agent finishes an episode.
    • ⚠️ I don't know if this is the correct way to address this problem. Please let me know what this should look like since I don't 100% grok the PettingZoo API.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

1. Add the missing `_cumulative_rewards` property
2. Update `agent_selection` to not error out when an agent finishes an episode.
@hvpeteet hvpeteet marked this pull request as ready for review October 15, 2021 17:23
@maryamhonari maryamhonari self-requested a review October 15, 2021 18:19
@miguelalonsojr miguelalonsojr merged commit ad9282b into develop-petting-api Nov 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-petting-api-fixes-hvpeteet branch November 10, 2021 15:04
miguelalonsojr pushed a commit that referenced this pull request Jan 27, 2022
1. Add the missing `_cumulative_rewards` property
2. Update `agent_selection` to not error out when an agent finishes an episode.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants