Fix for critic normalization bug #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamhonari
approved these changes
Oct 29, 2021
| seed=seed, | ||
| param_manager=EnvironmentParameterManager(), | ||
| ) | ||
| ppo_trainer = trainer_factory.generate(brain_name) |
There was a problem hiding this comment.
Nit: these should be sac_trainers in this method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Fixes a bug where the critic is not normalized during training.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#5583
Types of change(s)
Checklist
Other comments