Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TouchedTarget() methods from examples #5772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TV4Fun
Copy link

@TV4Fun TV4Fun commented Aug 5, 2022

Proposed change(s)

Crawler, Walker, and Worm all have TouchedTarget methods to add +1 reward
that are, as near as I can tell, completely unused. These are not mentioned
anywhere in documentation and are potentially very confusing to someone
examining the example code. Remove this methods to make the code cleaner
and easier to read.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Replacing #5768 so I am not merging from my main branch.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Crawler, Walker, and Worm all have TouchedTarget methods to add +1 reward
that are, as near as I can tell, completely unused. These are not mentioned
anywhere in documentation and are potentially very confusing to someone
examining the example code. Remove this methods to make the code cleaner
and easier to read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant