Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5799 #5820

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix #5799 #5820

merged 1 commit into from
Jun 6, 2023

Conversation

JesseTG
Copy link
Contributor

@JesseTG JesseTG commented Nov 21, 2022

Proposed change(s)

Fix #5799

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

#5799

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works Works on my machine.
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable) Not applicable.
  • Updated the migration guide (if applicable) Not applicable.

Other comments

@miguelalonsojr miguelalonsojr self-requested a review June 6, 2023 11:06
@miguelalonsojr miguelalonsojr merged commit 7a3c26a into Unity-Technologies:main Jun 6, 2023
miguelalonsojr added a commit that referenced this pull request Jun 6, 2023
@miguelalonsojr
Revert "Fix #5799 (#5820)"
17dd999 
This reverts commit 7a3c26a.
@miguelalonsojr miguelalonsojr mentioned this pull request Jun 6, 2023
Merged
@miguelalonsojr
Copy link
Collaborator

This should be sent to the develop branch, not main. Can you resubmit the patch to develop?

miguelalonsojr added a commit that referenced this pull request Jun 6, 2023
@miguelalonsojr
Revert "Fix #5799 (#5820)" (#5926)
29a30d4 
This reverts commit 7a3c26a.
@JesseTG JesseTG mentioned this pull request Jul 21, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelalonsojr miguelalonsojr miguelalonsojr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler errors when using IAsyncEnumerable<T> with .NET Standard 2.1 enabled
2 participants
@JesseTG @miguelalonsojr