Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience Features #5842

Merged
merged 14 commits into from
Dec 14, 2022
Merged

Convenience Features #5842

merged 14 commits into from
Dec 14, 2022

Conversation

miguelalonsojr
Copy link
Collaborator

@miguelalonsojr miguelalonsojr commented Dec 8, 2022

Proposed change(s)

  • Added feature to training area replicator to optionally specify replications in builds only.
  • Added model carousel to facilitate recording videos of training progress given a set of policies.
  • Added config feature to distribute checkpointing throughout training.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@miguelalonsojr miguelalonsojr changed the title Added feature to training area replicator to optionally specify repli… Convenience Features Dec 8, 2022
@miguelalonsojr miguelalonsojr marked this pull request as ready for review December 8, 2022 21:10
@miguelalonsojr miguelalonsojr enabled auto-merge (squash) December 8, 2022 21:14

m_StepsSinceLastSwitch++;

if (m_StepsSinceLastSwitch >= m_SecondsBetweenSwitches * k_FixedUpdatePerSecond || m_ForceNext)
Copy link
Contributor

@taozhuo taozhuo Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m_ForceNext has not been set to true anywhere in the code. If it's related to then use "Force Next" to advance., is there a place we need to set it to true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is. It's in the editor inspector window when you click on an object this has this script attached to it. This is a monobehaviour script, so any public property shows up in the inspector window for any object that has this script attached to it.

@miguelalonsojr miguelalonsojr merged commit 9ee3ff0 into develop Dec 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the develop-convenience-features branch December 14, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants