Skip to content

Conversation

simoninithomas
Copy link
Contributor

Proposed change(s)

Describe the changes made in this PR.

  • Context: Google Colab updated their machines to Python 3.10.12 I suppose during the night since there's no information on the release notes.

  • Problem: MLAgents requires Python <= 3.10.11

  • Solution: Update the two setup.py

  • For now I updated to 3.10.12 but given how Google Colab loves to change Python version every month we should maybe remove the .11 .12 part? And just replace by <= 3.10?

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

*python_requires from <= 3.10.11 to 3.10.12
*python_requires from <= 3.10.11 to 3.10.12
Copy link
Contributor

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelalonsojr miguelalonsojr merged commit e2e0768 into Unity-Technologies:develop Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants