Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pdbs for unityjit and unityaot profiles #1156

Open
wants to merge 660 commits into
base: unity-main
Choose a base branch
from

Conversation

joncham
Copy link
Member

@joncham joncham commented Mar 8, 2019

Any reason not to include these in the builds.zip? It allows for line numbers in class library exceptions and stack traces.

mderoy and others added 30 commits August 6, 2018 09:20
…table-android

Fix double gchandle free in thread detach logic (1062208)
…rict-mode

Add option for strict write barriers
…debugger-sync

Apply debugger changes from il2cpp 0c52b0b5b2babc2cbec886b8ef8015f682…
…offset-initialization

Fix issue where get offset could return 0 when the type is uninited
Use LF line endings on all perl build scripts
…er types are encountered with 'unmanaged' constraint.
…9236

Properly inflate pointer types in inflate_generic_type (case 1069236)
…5895

Don't try to access metadata for dynamic method (case 1065895)
…-hang-on-connection-close-during-readwrite

[tls] Fix read/write ignoring error code and requesting more read/write calls
The thread local storage of sequence points and method execution
contexts between IL2CPP and the mono debugger code was only being
synchronized at certain times, mainly when breakpoints were processed.
This could lead to a loss of synchronization after functions are exited
and debugger frame commands accessing invalid stack data. This change
adds synchronization for these data structures right before any managed
method exit, when the method execution context for that method is
destroyed. Also optimizing memory allocations by only allocating when
the stack grows and just reusing the memory otherwise.
…xceptions

Fix issue where loopback interface causes exception 1027045
…k-frames-sync

Increasing sync for i2cpp debugger stack frames (case 1064723)
…ver-clientauth-error-on-no-certificate

 UnityTls server no longer throws an exception if there is no client cert during client authentication
…-backtrace

Implement mono_unity_backtrace_from_context same as old mono (case 1074280)
Josh Peterson and others added 20 commits February 8, 2019 13:38
…-agent

 Sync the debugger-agent.c with the IL2CPP repo
…3205

Grow StackSlotInfo array rather than asserting (case 1103205)
…roid-tickcount

[Android] Fix the issue that Environment.TickCount returns wrong value…
…ocation

[Case 1084800] Fix issue where TLS requests would reallocate a buffer when it could reuse it
Revert part of #1131
as it causes hangs in calls to CancelSynchronousIo
…ializer-fix

Fix serialization issue with DataContractJsonSerializer UseSimpleDictionaryFormat (case 1070667)
…dfile-blocking

Fix interrupting blocking file IO on Windows.
…etthreadcontext

Bump bdwgc submodule to get fix for GetThreadContext (case 1114668)
@joncham joncham self-assigned this Mar 8, 2019
@joshpeterson
Copy link

Will this increase the installation size for customers?

@joncham
Copy link
Member Author

joncham commented Mar 8, 2019

I'll have to check, I think we explicitly only copy the assemblies not the pdbs for players. The Editor would be a larger install since the mono install will get bigger.

@joshpeterson
Copy link

Ok, I'm fine wit this change then.

@unity-cla-assistant
Copy link
Collaborator

unity-cla-assistant commented May 19, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 10 committers have signed the CLA.

✅ joshpeterson
✅ ashwinimurt
✅ UnityAlex
❌ jechter
❌ dbuckley3d
❌ vargaz
❌ Josh Peterson
❌ lateralusX
❌ mderoy
❌ netizen539


Josh Peterson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.