2023.1: Avoid throwing TypeLoadException for generic 2D arrays (case UUM-34854) #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mono was a bit too aggressive with its TypeLoadException processing, not allowing some valid code in this case. This change applies the fix from: dotnet/runtime#85828
This was referenced Jun 6, 2023
Saiprasad945
changed the title
joshpeterson
approved these changes
Jun 6, 2023
jhcdunity3d
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono was a bit too aggressive with its TypeLoadException processing, not allowing some valid code in this case. This change applies the fix from:
dotnet/runtime#85828
Bug: https://jira.unity3d.com/browse/UUM-34854
Backport: https://jira.unity3d.com/browse/UUM-34901
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed UUM-34854 @Saiprasad945:
Mono: Avoid an incorrect TypeLoadException when a generic type has a field which is a 2D array of itself..
Comments to reviewers
Cherry-pick is [CleanGraft]
PR to Main: #1774