Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement readiness for simple gameserver #36

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

eth0net
Copy link
Contributor

@eth0net eth0net commented Nov 27, 2023

Implement the Server Readiness feature for the simple gameserver example.

Includes an SDK update, which has been merged and released.

Also creates a Go Workspace to ease working with multiple Go Modules.

@eth0net eth0net requested a review from a team as a code owner November 27, 2023 14:43
@eth0net eth0net marked this pull request as draft November 27, 2023 14:45
@eth0net
Copy link
Contributor Author

eth0net commented Nov 27, 2023

Currently waiting on Unity-Technologies/unity-gaming-services-go-sdk#19 before this can be merged. The linting is failing due to the Go Workspace replace statement which can be removed after the SDK PR merges.

@eth0net eth0net marked this pull request as ready for review November 28, 2023 12:52
@eth0net
Copy link
Contributor Author

eth0net commented Nov 28, 2023

The SDK has been released and this PR updated, this is now ready for review 🚀

kaschula
kaschula previously approved these changes Nov 28, 2023
simple-game-server-go/internal/game/allocated.go Outdated Show resolved Hide resolved
simple-game-server-go/internal/game/allocated.go Outdated Show resolved Hide resolved
@eth0net eth0net requested a review from nweedon-u December 6, 2023 15:36
@eth0net eth0net dismissed nweedon-u’s stale review April 5, 2024 11:30

made the changes

@eth0net eth0net merged commit 812ab32 into main Apr 5, 2024
2 checks passed
@eth0net eth0net deleted the feat/simple-game-server-readiness branch April 5, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants