Skip to content

cache user/group exists #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

cache user/group exists #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8491519
cache user/group exists
simonLeary42 Apr 7, 2025
d76251a
handle null edge case
simonLeary42 Apr 7, 2025
fe080d2
type annotations
simonLeary42 Apr 7, 2025
6c6e179
oops
simonLeary42 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion resources/lib/UnityGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,14 @@ public function getPIUID()
*
* @return bool true if yes, false if no
*/
public function exists()
public function exists(bool $ignorecache = false): bool
{
if (!$ignorecache) {
$cached_pi_groups = $this->REDIS->getCache("sorted_pi_groups", "");
if (!is_null($cached_pi_groups)) {
return in_array($this->getPIUID(), $cached_pi_groups);
}
}
return $this->getLDAPPiGroup()->exists();
}

Expand Down
8 changes: 7 additions & 1 deletion resources/lib/UnityUser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,14 @@ public function getLDAPGroup()
return $this->LDAP->getGroupEntry($this->uid);
}

public function exists()
public function exists(bool $ignorecache = false): bool
{
if (!$ignorecache) {
$cached_users = $this->REDIS->getCache("sorted_users", "");
if (!is_null($cached_users)) {
return in_array($this->uid, $cached_users);
}
}
return $this->getLDAPUser()->exists() && $this->getLDAPGroup()->exists();
}

Expand Down
Loading