improve ssh key validation #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
catch-ssh-key-edge-cases
branch
from
a99ea4f to
d2608ca
Compare
simonLeary42
added a commit
that referenced
this pull request
Apr 30, 2025
* improve ssh key validation * catch all throwables * trim should be done externally * phpunit expect warning * put back checks to please phpunit * add comments, try out removing digits check * remove digits check * remove use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179 added failing tests, this PR makes those tests pass. Also used
UnitySitefor ajax ssh key validation rather than usingphpseclibdirectly in both places. Also added a simple test for ajax ssh key validation.I had to remove the
autoload.phpfrom this file since it tries to open external connections. I think that's fine since this file is so trivial, but would like a second opinion. Along with the external connections it also sets up$SSO,$USER,$OPERATOR,$_SESSIONkeysSSOis_adminuser_existsis_pi