Skip to content

update ssh key adding logic #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

update ssh key adding logic #214

merged 2 commits into from
Jun 3, 2025

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Apr 30, 2025 •
edited
Loading

changes:

  • instead of doing ssh key validation in each branch of the switch case, do it in one place at the end
  • make an HTTP bad request if required headers are not set
    • create a general purpose function for reading headers and sending HTTP bad request if headers don't exist
  • replace invalid_ssh_dialog with general purpose alert function
  • replace UnitySite::removeTrailingWhitespace with array_map("trim")

issues:

Screen.Recording.2025-04-30.at.4.26.32.PM.mov

@simonLeary42 simonLeary42 marked this pull request as draft April 30, 2025 20:28
@simonLeary42 simonLeary42 marked this pull request as ready for review June 3, 2025 14:54
@simonLeary42 simonLeary42 merged commit 38782ca into main Jun 3, 2025
2 of 3 checks passed
@simonLeary42 simonLeary42 deleted the validate-ssh-keys branch June 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generated, github keys are not validated
1 participant
@simonLeary42