Skip to content

Fix user init in pi-mgmt.php #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2025
Merged

Fix user init in pi-mgmt.php #274

merged 4 commits into from
Jul 13, 2025

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Jul 12, 2025 •
edited
Loading

  • removed redundant call to UnityUser->init() with the wrong arguments
  • added test for approving a user to join a PI from pi-mgmt.php
  • modified tests to use http_post
  • to fix testing issues, made $LDAP a singleton

@simonLeary42 simonLeary42 changed the title Fix user init pi mgmt Fix user init in pi-mgmt.php Jul 12, 2025
@simonLeary42 simonLeary42 requested a review from bryank-cs July 12, 2025 14:25
@simonLeary42 simonLeary42 merged commit 1e05710 into main Jul 13, 2025
3 checks passed
@simonLeary42 simonLeary42 deleted the fix-user-init-pi-mgmt branch July 13, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryank-cs bryank-cs bryank-cs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonLeary42 @bryank-cs