Skip to content

Conversation

simonLeary42
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error messages by replacing generic \ensure() function calls with more specific ensureExists() method calls on LDAP entry objects. The change provides better error context by indicating which specific entry doesn't exist when validation fails.

  • Replaces global \ensure($this->exists()) calls with $this->entry->ensureExists()
  • Updates subproject commit reference for phpopenldaper library
  • Affects multiple getter methods and initialization functions across user, organization, and group classes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
resources/lib/phpopenldaper Updates subproject commit hash
resources/lib/UnityUser.php Replaces ensure calls in getter methods with entry-specific ensureExists
resources/lib/UnityOrg.php Updates ensure call in organization initialization
resources/lib/UnityGroup.php Updates ensure calls in group initialization and commented code

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@simonLeary42 simonLeary42 force-pushed the ensure-exists2 branch 3 times, most recently from f5363ee to 16ee9b0 Compare September 23, 2025 15:49
@simonLeary42 simonLeary42 merged commit bcdd3bf into main Sep 23, 2025
2 checks passed
@simonLeary42 simonLeary42 deleted the ensure-exists2 branch September 23, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant