-
Notifications
You must be signed in to change notification settings - Fork 39
fix: update discovery profile specification links #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| spec: 'https://ucp.dev/specs/shopping', | ||
| spec: 'https://ucp.dev/specification/shopping', | ||
| rest: { | ||
| schema: 'https://ucp.dev/services/shopping/openapi.json', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is also outdated in main branch @0x8000-0000 also get a 404 here. Should it be https://ucp.dev/services/shopping/rest.openapi.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingyli - WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please update the schema URI here to https://ucp.dev/services/shopping/rest.openapi.json
Thanks @oluwatimio for catching it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8b10764 to
c6a5343
Compare
Outdated links pointing to 'https://ucp.dev/specs/shopping' were returning 404 errors. This change updates all discovery profiles and documentation in the samples repository to use the current 'https://ucp.dev/specification' structure. - rest/python/server: Updated 'discovery_profile.json' and 'README.md'. - rest/python/client: Regenerated 'happy_path_dialog.md' by running the updated server and client. - rest/nodejs: Updated discovery service logic in 'discovery.ts'. - a2a/business_agent: Updated 'ucp.json' and 'agent_card.json' data files. - a2a/chat-client: Updated 'agent_profile.json'. These updates ensure that discovery responses from sample implementations point to valid, working specification pages.
Outdated links pointing to 'https://ucp.dev/specs/shopping' were returning 404 errors. This change updates all discovery profiles and documentation in the samples repository to use the current 'https://ucp.dev/specification' structure.
These updates ensure that discovery responses from sample implementations point to valid, working specification pages.