refactor: rename and version service transport definitions#154
Merged
refactor: rename and version service transport definitions#154
Conversation
5257c4f to
523cb0f
Compare
wry-ry
approved these changes
Feb 4, 2026
523cb0f to
bcaa730
Compare
bcaa730 to
2fb3a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the names and post-processing applied to the transport schema files (currently, just the files in https://github.com/Universal-Commerce-Protocol/ucp/tree/main/source/services/shopping).
Before #125, there was additional processing that was used to generate the published spec files. This processing renamed the files, creating a set of
x.{openapi,openrpc}.jsonfiles that get published (e.g., embedded, MCP). The embedded file underwent particular processing — the source file for it is not an OpenRPC doc at all, but was turned into one as part of this script.This PR applies the processing that was previously applied when generating the final spec files directly to the schemas themselves. Mostly, this is just renaming the files, but for the embedded schema, more changes are made to generate a valid OpenRPC file (add
openrpc,info, andserverfields, movedelegationstox-delegationsas it is not a standard field). I have also added one additional bit of post-processing to all the files, to ensure that their respectiveinfo.versionfields correctly represent the UCP version to which they apply.