Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 104: save complete config in file #106

Conversation

felixrieg
Copy link
Collaborator

Fixes: #104

When clicking "Save All" it saves every variable, even the ones that got filled by the smt solver

@felixrieg felixrieg requested a review from ThiBruUU October 20, 2023 10:07
@ThiBruUU
Copy link
Collaborator

I don't have a Save-All button in the configurator. I only see the Save button, which saves your own selection of features.

SaveAll

@felixrieg
Copy link
Collaborator Author

I am starting to believe, that you don't start the extension from the code. It is not sufficient to load a different UVL.exe. You need to start the extension with F5, if you press F5 a new VSCode instance should spawn with all the changes.

@felixrieg
Copy link
Collaborator Author

@ThiBruUU Have you tried it again?

@ThiBruUU
Copy link
Collaborator

ThiBruUU commented Nov 2, 2023

I tried again. The "Save All" button is visible and works for features in my case. I also tried attributes and they weren't saved correctly when saving with the "Save All" button.

@felixrieg
Copy link
Collaborator Author

felixrieg commented Nov 2, 2023

@ThiBruUU Do you mean, that the numbers sometimes differ from what you configured?
Because I could reproduce this on main as well, so maybe this is a bug for a separate issue
Maybe try it on main as well, then we can create a new issue

@ThiBruUU
Copy link
Collaborator

ThiBruUU commented Nov 2, 2023

yes, exactly. When saving via the normal save, the number attribute was saved correctly. It was only saved with 0 when saving via save all.

@felixrieg
Copy link
Collaborator Author

Now I am confused. Is this a Bug exclusive to this issue or not? If so, could you give a detailed example

Copy link
Collaborator

@ThiBruUU ThiBruUU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess i made a mistake in the configuration step and set the feature with the attribute false, so the attribute is 0.0 in the save all action. If the feature is enabled, the correct number for the attribute is set in the json file.

@SundermannC SundermannC merged commit 3bf20b3 into Universal-Variability-Language:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Save Full Configuration
3 participants